The Scottish Parliament Building, ironically, the newest building in Edinburgh. I was expecting something more like the British Parliament building. It is next to Holyrood Mansion, so I'll give it props for that.
There were a lot of things that you just couldn't take pictures of, like all the museums. We went to a few museums, my favorite of which was the portrait gallery. They had a floor of Italian Renaissance paintings, which I have a soft spot for ever since my Medieval history class at Purdue. Those are the painting where they use metallic (especially gold) paints and draw halo's around religious figures. The paintings also depict women with very far back hairlines; the fashion at the time was to actually shave the closest 3 inches of hair to your face, then bleach the rest of it blond and have super pale skin. Since this was way before peroxide, women used horse urine and sat in the sun with covers over their faces to bleach their hair. The ammonia in the urine was activated in the sunlight and served as an early peroxide.
We also couldn't take pictures of the ghost tour (well- you could, I just refused to take my hands off my purse- I've heard terrible stories about thieves grabbing people's bags when they were engrossed in Scottish ghost stories) and I think I had a supernatural experience (or two) on the tour. The first was just seeing a guy standing in the alleyway with a top hat and a cloak and a vacant expression on his face; I figured he was one of the actors just hanging out to scare the next group of tourists, so I didn't think anything of it. It wasn't until I was telling the tour guide later that I knew he was going to jump out and scare us at the end that I started to think it was more than just an actor. She said that someone did jump out and scare us, but it wasn't anyone dressed like that. She said that I had (like several before me) described the night watchman of Cockburn road from the early 1800's. This explanation was at the end of the tour, after my other...experience. We went into one of the underground rooms that merchants used to store their goods in between workdays, and I felt immediately sick to my stomach as soon as I walked into the room. I instantly cursed the Indian food I'd had for dinner and left the room and stood in the hallway so I didn't puke. I waited outside until the tour guide was done explaining the story of that particular room- I didn't really pay attention- I was waiting for someone to jump out and scare me the whole time. The tour guide came out first and looked straight at me and asked if I felt like I was going to be sick and I explained that I did, but I felt fine as soon as I left the room. She said some people were more sensitive to the poltergeist than others...great. So in one night I saw the dead night watchman and was nauseated by a poltergeist raised by a group of Edinburgh Wiccans in 1996.
So that's pretty much my trip: castles, museums, nice restaurants, tours, shopping... and I loved every second of it. I'd go back in a heartbeat.